Skip to content

[FC: 0099] fix: add plugin_settings function in test settings#107

Merged
MaferMazu merged 1 commit intoopenedx:mainfrom
eduNEXT:bav/add-plugin-settings-function
Oct 21, 2025
Merged

[FC: 0099] fix: add plugin_settings function in test settings#107
MaferMazu merged 1 commit intoopenedx:mainfrom
eduNEXT:bav/add-plugin-settings-function

Conversation

@BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Oct 21, 2025 •
edited
Loading

Description

This PR adds the plugin_settings function to the test.py settings file.

Supporting Information

https://github.com/openedx/edx-platform/actions/runs/18655184882/job/53182435487?pr=37501#step:12:96

Merge Checklist

Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 21, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 21, 2025 •
edited
Loading

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 21, 2025
@BryanttV BryanttV changed the title fix: add plugin_settings function in test settings [FC: 0099] fix: add plugin_settings function in test settings Oct 21, 2025
@BryanttV BryanttV marked this pull request as ready for review October 21, 2025 18:08
@MaferMazu MaferMazu merged commit 7ad3981 into openedx:main Oct 21, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Oct 21, 2025
@MaferMazu MaferMazu mentioned this pull request Oct 21, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaferMazu MaferMazu MaferMazu approved these changes

@rodmgwgu rodmgwgu rodmgwgu approved these changes

@mariajgrimaldi mariajgrimaldi Awaiting requested review from mariajgrimaldi

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BryanttV @openedx-webhooks @MaferMazu @rodmgwgu